#24 add none option custom drawers #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a None option in Assets, Classes and Scenes Categories.
This is done in
SerializableInterfaceAdvancedDropdown.cs, but could've easily been done in every AdvancedDropdownItem Builder (e.g.SceneItemBuilder...). I would argue there's benefits in both methods.A side effect of adding a None option in every Category is that they all show they contain something. This changes the previous behaviour, but makes it so that the Categories always display in the same order. This makes using the Dropdown more intuitive and helps build muscle memory.
Note
Also added a Clear context menu, but this was technically out of scope. Just really simple to add... :v
Issue
This fixes #24